Skip to content

feat:Add Deleted status option to filter drawer UI #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Prashik-Sasane wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat:Add Deleted status option to filter drawer UI #549

Prashik-Sasane wants to merge 6 commits into from
+216 −88

Conversation

@Prashik-Sasane
Copy link
Contributor

@Prashik-Sasane Prashik-Sasane commented Jan 3, 2026 •
edited
Loading

Description

You can check the issue after clicking on the issue number (#482), and this PR fixes the issue when tasks are deleted. Then, it shows into a completed filter, and I add the deleted filter status option in UI, but it works fine for Taskserver, and when for taskchampion/taskReplica delete filter status option does not work, so I remove the deleted filter for the taskchampion server.

videos ( current behaviour)

taskchampion.mp4

Future improvement

  • Add test case for this PR
  • Enable Delete option for taskchampion(if exists)

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

@Prashik-Sasane Prashik-Sasane changed the title Add Deleted status option to filter drawer UI feat(#482):Add Deleted status option to filter drawer UI Jan 3, 2026
@SGI-CAPP-AT2
Copy link
Collaborator

SGI-CAPP-AT2 commented Jan 3, 2026

should not add toggle instead add new option of deleted in the same ui

@Prashik-Sasane
Copy link
Contributor Author

Prashik-Sasane commented Jan 3, 2026

i will do that just a moment

@Prashik-Sasane
Copy link
Contributor Author

Prashik-Sasane commented Jan 3, 2026

@SGI-CAPP-AT2 i add the delete option same like pending, complete instead of toggle check it once

@SGI-CAPP-AT2
Copy link
Collaborator

SGI-CAPP-AT2 commented Jan 3, 2026

@SGI-CAPP-AT2 i add the delete option same like pending, complete instead of toggle check it once

update PR description image

@SGI-CAPP-AT2
Copy link
Collaborator

SGI-CAPP-AT2 commented Jan 3, 2026

@Prashik-Sasane , This should also work when profile server is changed to CCSync or Taskchampion

@Prashik-Sasane
Copy link
Contributor Author

Prashik-Sasane commented Jan 3, 2026

@SGI-CAPP-AT2 now if any errors just let me knows

@Prashik-Sasane Prashik-Sasane changed the title feat(#482):Add Deleted status option to filter drawer UI feat:Add Deleted status option to filter drawer UI Jan 8, 2026
@SGI-CAPP-AT2
Copy link
Collaborator

SGI-CAPP-AT2 commented Jan 31, 2026

@Prashik-Sasane
Works fine for Taskserver Profile
but does not work as expected in case of taskchampion
Same task for completed and deleted is being shown

Completed Deleted
image image
Also there was no deleted task in this case

@SGI-CAPP-AT2
Copy link
Collaborator

SGI-CAPP-AT2 commented Jan 31, 2026

Also note that we have deprecated ccsync profile, You can remove ccsync logic from the pr

SGI-CAPP-AT2
SGI-CAPP-AT2 requested changes Jan 31, 2026
View reviewed changes
Copy link
Collaborator

@SGI-CAPP-AT2 SGI-CAPP-AT2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer above comments !

@Prashik-Sasane
Copy link
Contributor Author

Prashik-Sasane commented Feb 1, 2026

Also note that we have deprecated ccsync profile, You can remove ccsync logic from the pr

ok i will do that and update PR with description

@Prashik-Sasane
Copy link
Contributor Author

Prashik-Sasane commented Feb 1, 2026 •
edited
Loading

@SGI-CAPP-AT2 Could you check latest commit changes? and, its works for taskserver as 3 filter status (pending , deleted , completed) and for taskchampion/taskreplica as 2 filter status (pending, completed).

@SGI-CAPP-AT2
Copy link
Collaborator

SGI-CAPP-AT2 commented Feb 1, 2026

Can you add tags filter for Taskchampion (v3) which is currently missing?
#general > apply tags filters from android app

Also we are missing auto apply project filter, which does not populate tasks in v2, v3?
#576

@Prashik-Sasane
Copy link
Contributor Author

Prashik-Sasane commented Feb 1, 2026 •
edited
Loading

Can you add tags filter for Taskchampion (v3) which is currently missing? #general > apply tags filters from android app

Also we are missing auto apply project filter, which does not populate tasks in v2, v3? #576

ok i will do that so i need to push in this branch or new PR and also can you check this branch changes like it correct or not

@SGI-CAPP-AT2
Copy link
Collaborator

SGI-CAPP-AT2 commented Feb 1, 2026

Can you add tags filter for Taskchampion (v3) which is currently missing? #general > apply tags filters from android app
Also we are missing auto apply project filter, which does not populate tasks in v2, v3? #576

ok i will do that so i need to push in this branch or new PR and also can you check this branch changes like it correct or not

If you want to do, do it in this PR do not open new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SGI-CAPP-AT2 SGI-CAPP-AT2 SGI-CAPP-AT2 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Prashik-Sasane @SGI-CAPP-AT2